make ahash optional - #17
Open
Qix- wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This PR makes the
ahashdependency optional.ahashusesgetrandomunder the hood, which has a long-standing history of annoyances when building under WASM. If there are multiple crates that use varying versions ofgetrandomas transitive dependencies, it makes things impossible to build under WASM.In our case
regexsolverdoesn't need to be particularly fast or hardened under WASM, so disabling it (and by proxy,getrandom) and usingstd::collections::HashMapis the solution here.Totally understandable if you don't want to accept these changes; I figured it'd probably be helpful to someone else out there, and I was hoping not to have to maintain a fork of
regexsolver.Thank you for the amazing crate by the way.
Checklist
cargo fmt --all --checkandcargo clippy --all-targets -- -D warningspasscargo testandcargo test --no-default-featurespassCHANGELOG.mdis updated under## [Unreleased]