Skip to content

Fix dependency vulnerabilities and tooling compatibility - #131

Merged
Akrion merged 3 commits into
mainfrom
ia_fix_vulnerabilities
Sep 10, 2026
Merged

Akrion merged 3 commits into
mainfrom
ia_fix_vulnerabilities

Conversation

@Akrion

@Akrion Akrion commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

  • update fast-uri, js-yaml, and brace-expansion overrides to patched releases
  • refresh vulnerable transitive Babel and Browserslist dependencies, bringing npm audit to zero findings
  • upgrade TypeScript to 4.9.5 and TypeScript-ESLint to 5.59.0 for compatibility with query-string@9.5.1
  • configure Jest to transform the pure-ESM query-string dependency chain
  • apply the existing Prettier formatting requirement in src/rest.ts

Addresses Dependabot alert 67.

Validation

  • npm audit --audit-level=low — 0 vulnerabilities
  • npm run tscheck — passed
  • npm run lint — passed with 2 pre-existing non-null-assertion warnings
  • npm run build -- --stats=errors-warnings — passed with existing bundle-size warnings
  • credential-free Jest suites — 10 suites and 61 tests passed

@Akrion
Akrion requested a review from meruyert93 September 10, 2026 15:17
@Akrion Akrion self-assigned this Sep 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The debug test script and Windows-compatible Jest environment setup still need correction.

Pull request overview

This pull request patches dependency vulnerabilities and updates TypeScript/Jest tooling for pure-ESM compatibility.

Changes:

  • Refreshes vulnerable dependencies and overrides.
  • Upgrades TypeScript and TypeScript-ESLint.
  • Configures Jest for ESM dependencies and formats src/rest.ts.
File summaries
File Description
src/rest.ts Applies Prettier formatting.
package.json Updates tooling, overrides, and test configuration.
package-lock.json Refreshes dependency resolutions.
jest.config.js Enables transformation of ESM dependencies.
Review details

Suppressed comments (2)

package.json:68

  • The ESM loader is applied only to npm test, while test:debug still launches Jest without it. With the js-with-ts-esm preset and the pure-ESM query-string chain this PR is configuring around, npm run test:debug will not have the same module-loading setup and can fail before running tests. Apply the same NODE_OPTIONS to the debug script (or centralize the Jest launcher) so both supported test entry points use the required setup.
    "test": "NODE_OPTIONS='--loader ts-node/esm --experimental-specifier-resolution=node' jest --verbose --runInBand",

package.json:68

  • On Windows, npm runs scripts through cmd.exe, where NODE_OPTIONS='...' jest is parsed as an executable name rather than an environment assignment, so npm test fails before Jest starts. Invoke Jest through node with these flags (or add a cross-platform env helper) instead of relying on POSIX shell assignment.
    "test": "NODE_OPTIONS='--loader ts-node/esm --experimental-specifier-resolution=node' jest --verbose --runInBand",
  • Files reviewed: 2/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Akrion
Akrion merged commit e8a17b7 into main Sep 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants