Fix dependency vulnerabilities and tooling compatibility - #131
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The debug test script and Windows-compatible Jest environment setup still need correction.
Pull request overview
This pull request patches dependency vulnerabilities and updates TypeScript/Jest tooling for pure-ESM compatibility.
Changes:
- Refreshes vulnerable dependencies and overrides.
- Upgrades TypeScript and TypeScript-ESLint.
- Configures Jest for ESM dependencies and formats
src/rest.ts.
File summaries
| File | Description |
|---|---|
src/rest.ts |
Applies Prettier formatting. |
package.json |
Updates tooling, overrides, and test configuration. |
package-lock.json |
Refreshes dependency resolutions. |
jest.config.js |
Enables transformation of ESM dependencies. |
Review details
Suppressed comments (2)
package.json:68
- The ESM loader is applied only to
npm test, whiletest:debugstill launches Jest without it. With thejs-with-ts-esmpreset and the pure-ESMquery-stringchain this PR is configuring around,npm run test:debugwill not have the same module-loading setup and can fail before running tests. Apply the sameNODE_OPTIONSto the debug script (or centralize the Jest launcher) so both supported test entry points use the required setup.
"test": "NODE_OPTIONS='--loader ts-node/esm --experimental-specifier-resolution=node' jest --verbose --runInBand",
package.json:68
- On Windows, npm runs scripts through
cmd.exe, whereNODE_OPTIONS='...' jestis parsed as an executable name rather than an environment assignment, sonpm testfails before Jest starts. Invoke Jest throughnodewith these flags (or add a cross-platform env helper) instead of relying on POSIX shell assignment.
"test": "NODE_OPTIONS='--loader ts-node/esm --experimental-specifier-resolution=node' jest --verbose --runInBand",
- Files reviewed: 2/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
meruyert93
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast-uri,js-yaml, andbrace-expansionoverrides to patched releasesnpm auditto zero findingsquery-string@9.5.1query-stringdependency chainsrc/rest.tsAddresses Dependabot alert 67.
Validation
npm audit --audit-level=low— 0 vulnerabilitiesnpm run tscheck— passednpm run lint— passed with 2 pre-existing non-null-assertion warningsnpm run build -- --stats=errors-warnings— passed with existing bundle-size warnings