fix: read memory on Darwin without free - #1660
Open
stantheman0128 wants to merge 1 commit into
Open
stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
Darwin fell through to the Linux path and ran free -m, which is not installed, so cmdb printed command not found. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1367.
On Darwin, memory and swap fell through to the Linux default and ran
free -m. This Mac has nofree(command not found). Darwin now usessysctl hw.memsize,vm_stat, andsysctl vm.swapusage. Values are megabytes, matchingfree -m.get cmdbwas not run.prepared with Cursor
Verification
Red, this Mac:
Green:
total=16384ishw.memsizein MiB. Swap matchesvm.swapusage(1024.00Mtotal,223.19Mused,800.81Mfree).Made with Cursor