feat(keyboard): four G-leader sequence rows + display/aria hardening (RIG-2708) - #613
Merged
Merged
Conversation
|
Compass engineering docs preview: https://compass-ux-rig-2708-leader-s.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
force-pushed
the
compass-ux/rig-2708-leader-sequence-rows
branch
from
August 25, 2026 17:50
0fc1ff0 to
cacde85
Compare
rigel-mintaka
force-pushed
the
compass-ux/rig-2707-chord-grammar-helpers
branch
from
August 25, 2026 17:51
09f111f to
6a8939e
Compare
rigel-mintaka
force-pushed
the
compass-ux/rig-2708-leader-sequence-rows
branch
from
August 25, 2026 17:52
cacde85 to
21555fa
Compare
This was referenced Aug 25, 2026
rigel-mintaka
marked this pull request as ready for review
August 25, 2026 18:28
rigel-mintaka
force-pushed
the
compass-ux/rig-2707-chord-grammar-helpers
branch
from
August 26, 2026 03:31
6a8939e to
24df261
Compare
rigel-mintaka
force-pushed
the
compass-ux/rig-2708-leader-sequence-rows
branch
from
August 26, 2026 03:31
21555fa to
b10833f
Compare
Base automatically changed from
compass-ux/rig-2707-chord-grammar-helpers
to
main
August 26, 2026 04:26
mattwilkinsonn
force-pushed
the
compass-ux/rig-2708-leader-sequence-rows
branch
from
August 26, 2026 04:26
b10833f to
8b976fe
Compare
…(RIG-2708) Adds the four Go-to leader sequences from the frozen leader-chords design (`docs/designs/product/compass-leader-chords/design.md`, T2 / §A4-A5) to `DEFAULT_KEYMAP` and hardens the two shipped chord scanners so a sequence renders correctly everywhere and never reaches `aria-keyshortcuts`. - `DEFAULT_KEYMAP`: a new `// Go-to sequences (RIG-2484)` block with `G B → view.bridge`, `G L → view.backlog`, `G D → view.done`, `G S → view.settings`, each placed after any existing modifier row for the same command so the modifier chord stays the first match. - `shortcutForAria` now skips sequence rows (`chordSegments(entry.chord).length === 1`): a sequence-only command returns `undefined` (its writer omits the attribute) and a dual-bound command returns its modifier chord. A press-then-press sequence has no valid WAI-ARIA representation, so the skip is mandatory and makes the result row-order-independent. - `shortcutFor` now returns `formatChordForDisplay` of the first matching row and does NOT skip sequences, so `view.backlog`/`view.done` display `"G then L"`/`"G then D"` and keep their point-of-use chip and title; a dual-bound command still shows its modifier chord because that row is first. - The `?` overlay join formats via `formatChordForDisplay`, so a sequence row reads `"G then B"` instead of the misleading `"G B"`. Tests: `keymap.test.ts` moves `view.backlog` out of the `shortcutFor` miss group, adds a sequence-only-display case, a dual-bound modifier-wins case, and a `DEFAULT_KEYMAP` authoring-invariant block (every sequence is two modifier-less segments; no leader prefix is also a complete single chord); `ShortcutsOverlay.test.tsx` updates the bridge-filter row count 1→2 and asserts the formatted `"G then B"`; `Palette.test.tsx` asserts Backlog/Done carry no `aria-keyshortcuts` but a `"Backlog (G then L)"`/`"Done (G then D)"` title while Bridge keeps `aria-keyshortcuts="Control+B"`. Stacked on RIG-2707 (the sequence-grammar helpers). The dispatcher leader runtime that makes these chords fire is T3 (RIG-2709); until it lands the rows are advertised only through the discoverability net, which is why T2 and T3 ship in one stack. Ledger-impact: none. DL-248..DL-252 for this record landed with the design PR (#544). Refs RIG-2708 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-ux/rig-2708-leader-sequence-rows
branch
from
August 26, 2026 04:40
8b976fe to
5c93e2e
Compare
mattwilkinsonn
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 3 PRs:
mainAdds the four Go-to leader sequences from the frozen leader-chords design (
docs/designs/product/compass-leader-chords/design.md, T2 / §A4-A5) toDEFAULT_KEYMAPand hardens the two shipped chord scanners so a sequence renders correctly everywhere and never reachesaria-keyshortcuts.DEFAULT_KEYMAP: a new// Go-to sequences (RIG-2484)block withG B → view.bridge,G L → view.backlog,G D → view.done,G S → view.settings, each placed after any existing modifier row for the same command so the modifier chord stays the first match.shortcutForArianow skips sequence rows (chordSegments(entry.chord).length === 1): a sequence-only command returnsundefined(its writer omits the attribute) and a dual-bound command returns its modifier chord. A press-then-press sequence has no valid WAI-ARIA representation, so the skip is mandatory and makes the result row-order-independent.shortcutFornow returnsformatChordForDisplayof the first matching row and does NOT skip sequences, soview.backlog/view.donedisplay"G then L"/"G then D"and keep their point-of-use chip and title; a dual-bound command still shows its modifier chord because that row is first.?overlay join formats viaformatChordForDisplay, so a sequence row reads"G then B"instead of the misleading"G B".Tests:
keymap.test.tsmovesview.backlogout of theshortcutFormiss group, adds a sequence-only-display case, a dual-bound modifier-wins case, and aDEFAULT_KEYMAPauthoring-invariant block (every sequence is two modifier-less segments; no leader prefix is also a complete single chord);ShortcutsOverlay.test.tsxupdates the bridge-filter row count 1→2 and asserts the formatted"G then B";Palette.test.tsxasserts Backlog/Done carry noaria-keyshortcutsbut a"Backlog (G then L)"/"Done (G then D)"title while Bridge keepsaria-keyshortcuts="Control+B".Stacked on RIG-2707 (the sequence-grammar helpers). The dispatcher leader runtime that makes these chords fire is T3 (RIG-2709); until it lands the rows are advertised only through the discoverability net, which is why T2 and T3 ship in one stack.
Ledger-impact: none. DL-248..DL-252 for this record landed with the design PR (#544).
Refs RIG-2708
Co-authored-by: Matt Wilkinson matt@rigel.build