feat(compass-app): darwin build path via build-tag restructure (RIG-2753, T2) - #640
Merged
Merged
Conversation
…753, T2) Restructure go/cmd/compass-app build tags so darwin compiles the real gtk3 entrypoint without double-compiling the !gtk3 stubs. Each gtk3-tagged file gaining darwin moves unix && gtk3 -> (linux && gtk3) || darwin; each stub pair narrows unix && !gtk3 -> linux && !gtk3 (else a darwin build, which is unix with no gtk3 tag, compiles both the retagged real file and its stub = duplicate-symbol break, e.g. windowFromContext). The gtk3-tagged test suite stays unix && gtk3 (Linux-only; darwin coverage is the manual launch smoke + T3's macos-14 compile gate, per the record's honesty note). Implements DL-263 lane prerequisite; the real darwin compile runs in T3's macos-14 CI job (not runnable on Linux — darwin cgo needs the macOS SDK). Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-native-rig-2753-darw.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
August 26, 2026 03:43
mattwilkinsonn
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure go/cmd/compass-app build tags so darwin compiles the real gtk3
entrypoint without double-compiling the !gtk3 stubs. Each gtk3-tagged file
gaining darwin moves unix && gtk3 -> (linux && gtk3) || darwin; each stub pair
narrows unix && !gtk3 -> linux && !gtk3 (else a darwin build, which is unix with
no gtk3 tag, compiles both the retagged real file and its stub = duplicate-symbol
break, e.g. windowFromContext). The gtk3-tagged test suite stays unix && gtk3
(Linux-only; darwin coverage is the manual launch smoke + T3's macos-14 compile
gate, per the record's honesty note).
Implements DL-263 lane prerequisite; the real darwin compile runs in T3's
macos-14 CI job (not runnable on Linux — darwin cgo needs the macOS SDK).
Co-authored-by: Matt Wilkinson matt@rigel.build