feat(stack): pgid-record v2 kind-tagged union for container teardown (RIG-2760, T8a) - #644
Merged
Merged
Conversation
|
Compass engineering docs preview: https://compass-native-rig-2760-pgid.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
force-pushed
the
compass-native/rig-2760-pgid-v2
branch
from
August 26, 2026 04:58
9d390fc to
70d0d8d
Compare
…(RIG-2760, T8a) Grow the stack.pgids entry line into a kind-tagged discriminated union so a container-backed child (S4's rootless-podman postgres) can be torn down by its stable name, alongside the existing process-group children torn down by identity-checked pgid. - v2 entry grammar: 'proc <component> <pgid> <starttime>' | 'ctr <component> <name>'. A v1 record (untagged 3-field proc lines) still parses, as all-process entries (v2 is a strict superset). - Cross-version safety by two guards (DL-262): forward — a v2 reader hard-errors on an unknown/newer version; reverse — a shipped v1 parser meeting a v2 record hard-errors by the entry grammar (4-field proc / unknown ctr token), never half-parsing a record it cannot fully understand. - ContainerController Deps seam (Exists/Stop/Remove) mirrors GroupSignaller: DownDetached dispatches per entry kind (group signal vs podman stop/rm -f). Nil until T8 wires the real podman adapter; no container entry is written yet, so the seam is never dereferenced. Realizes DL-262 (pgid-record v2). The container write path + podman adapter are T8's slice. Co-authored-by: Matt Wilkinson <matt@rigel.build> Ledger-impact: none (realizes frozen DL-262; no ledger row change)
rigel-mintaka
force-pushed
the
compass-native/rig-2760-pgid-v2
branch
from
August 26, 2026 05:04
70d0d8d to
68a2ebf
Compare
rigel-mintaka
marked this pull request as ready for review
August 26, 2026 05:07
mattwilkinsonn
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grow the stack.pgids entry line into a kind-tagged discriminated union so a
container-backed child (S4's rootless-podman postgres) can be torn down by its
stable name, alongside the existing process-group children torn down by
identity-checked pgid.
A v1 record (untagged 3-field proc lines) still parses, as all-process entries
(v2 is a strict superset).
on an unknown/newer version; reverse — a shipped v1 parser meeting a v2 record
hard-errors by the entry grammar (4-field proc / unknown ctr token), never
half-parsing a record it cannot fully understand.
DownDetached dispatches per entry kind (group signal vs podman stop/rm -f).
Nil until T8 wires the real podman adapter; no container entry is written yet,
so the seam is never dereferenced.
Realizes DL-262 (pgid-record v2). The container write path + podman adapter are
T8's slice.
Co-authored-by: Matt Wilkinson matt@rigel.build
Ledger-impact: none (realizes frozen DL-262; no ledger row change)