Repository navigation
feat(minor): read and write portable bytes through RawSpan (rebased #31) - #32
Merged
Merged
Conversation
lemire
force-pushed
the
rawspan-rebased
branch
from
October 26, 2026 19:02
7688284 to
7ae2368
Compare
Contributor
|
Great, thanks @lemire ! I gave access in case you need to make a tweak to the other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #31 by @vsarunas, rebased onto master (a1c1338, CRoaring 5.4.0 and the new UBSan workflow). The commit and its author are unchanged. #31 comes from a fork that doesn't allow maintainer edits, so it couldn't be rebased in place.
CRoaring 5.4.0 makes portable frozen views tolerate unaligned payloads (RoaringBitmap/CRoaring#918, RoaringBitmap/CRoaring#920). With it, the view tests in this PR pass under UBSan, including the one that reads a bitmap one byte off alignment. They didn't before.
Locally (macOS, Swift 6.2.4): 91 tests pass with
swift test,--sanitize=addressand--sanitize=undefined(UBSAN_OPTIONS=halt_on_error=1).