Harden companion bridge against top conversational pain points - #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The bridge was conversationally capable but several failures could still break trust or continuity: model and TTS faults ended sessions, low-confidence speech could be treated as understood, episodic callbacks were not persona-scoped, a search outage could give the model room to improvise a fresh fact, and proactive-speech preference persistence was not host-owned.
This PR makes those boundaries explicit and testable before physical-robot qualification.
User impact
Validation
python -m unittest discover -s bridge -p "test_*.py": 543 passed.python bridge/companion_harness_qualification.py --run: 32 passed, 20/20 controls, no skips.gemma4:e2b-it-qatCharacter Lock red team: 29/29 passed, zero validation failures and zero runner errors.git diff --check: clean.Scope and residual limits
person_count; this does not claim speaker identity.