Conversation
seks99x
force-pushed
the
fix-files-from
branch
from
September 17, 2026 12:35
c9edc24 to
44f3cb1
Compare
The recent path confinement patch caused an ELOOP error when local or SSH users tried to use a --files-from list located outside the confined root. This happened because the code treated the argument as if its always an operator-path peer. CLI arguments provided locally or over SSH are trusted, so the strict boundary check should only apply to untrusted clients connecting to a background daemon.
seks99x
force-pushed
the
fix-files-from
branch
from
September 17, 2026 14:49
44f3cb1 to
3e715aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rsync 3.5.0 path confinement patch of the
files-fromoption treated the path as an operator-path for all cases (it only acts as an untrusted peer path in the daemon side), which makes it inconsistent with non-operator trusted paths behavior (log-file, filter, write-batch, read-batch, password-file, etc) when there is a root confined.In local and ssh processes the path is coming from a trusted argument and shouldn't be treated as operator path.