Skip to content

Fix CodeTailor question lookup failing in cloned courses #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aspadiyath wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CodeTailor question lookup failing in cloned courses #1450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions bases/rsptx/book_server_api/routers/coach.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,18 @@ async def parsons_scaffolding(
try:
basecourse = getattr(course, "base_course", None)
question = await fetch_question(problem_id, basecourse=basecourse)
if not question:
# A cloned course keeps the original book's base_course on its
# question rows, and selectquestion can pull an exercise from
# another book, so the base-course-scoped lookup misses even
# though the question exists. Fall back to a global name match --
# the same resolution get_question_source and /htmlsrc use.
question = await fetch_question(problem_id)
if question:
rslogger.warning(
f"CodeTailor: '{problem_id}' not in base course '{basecourse}' "
f"(likely a cloned course); resolved via global name match"
)
if not question:
rslogger.error(
f"CodeTailor: no question found for problem_id '{problem_id}'"
Expand Down
Loading