Fix Wine child window wglChoosePixelFormatARB not finding any formats#284
Open
FyorDev wants to merge 1 commit into
Open
Fix Wine child window wglChoosePixelFormatARB not finding any formats#284FyorDev wants to merge 1 commit into
FyorDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For embedded child windows in Wine,
wglChoosePixelFormatARBcan returnnum_formats == 0resulting in an error. When handling this by providing a fallback, the issue is resolved. One might argue that this is a Wine issue and is not to be fixed here, but this fix handles the case for me nicely and may benefit Rust developers on Linux that run Windows DAWs on Wine.I bumped into this while developing a nice-plug vst3 plugin and opening this in FL Studio running on Wine on Arch (Wayland + NVIDIA).
The full error FL Studio passed to me was: