Repository navigation
Add SecretPrime type alias - #716
Merged
Merged
Conversation
Partially resolves the zeroization problems around `PrecomputedValues` by storing `p` and `q` as `MontyParams<BoxedUint>`, which avoids the problems surrounding the `Arc`. It doesn't completely address the issue though, as several APIs still need a proper `BoxedMontyParams` input which we don't yet erase. We need to provide an API that's able to obtain exclusive access to the `Arc` in certain cases that can erase these intermediates, but for now this at least allows the `Zeroize` impl for `PrecomputedValues` to be complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves the zeroization problems around
PrecomputedValuesby storingpandqasMontyParams<BoxedUint>, which avoids the problems surrounding theArc.It doesn't completely address the issue though, as several APIs still need a proper
BoxedMontyParamsinput which we don't yet erase.We need to provide an API that's able to obtain exclusive access to the
Arcin certain cases that can erase these intermediates, but for now this at least allows theZeroizeimpl forPrecomputedValuesto be complete.