Fix multiple FTPS upload issues

[jeremyestein]

You always receive one email notification per file uploaded, even if sent on the same connection.

The only reasonable workaround is to tar up the files to be uploaded, which this PR implements. So this fixes the underlying problem described by #67 , using a slightly different method.

Also have fixed #74 by handling remote paths properly.

It also works around #68 because now there will never be duplicate named uploads. It shifts this problem to the DSH extractor script, described in #84

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.42%. Comparing base (4251bc1) to head (32233f8).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #90      +/-   ##
==========================================
+ Coverage   50.44%   51.42%   +0.98%     
==========================================
  Files          14       14              
  Lines         563      595      +32     
  Branches       47       48       +1     
==========================================
+ Hits          284      306      +22     
- Misses        263      273      +10     
  Partials       16       16              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[skeating]

Seems very sensible to me

[thompson318]

Looks sensible. A couple of minor comments.
More general question: I don't think this deletes the temporary archives, so at some point we'll have to do a disk clean up of them. Should we implement temporary archive deletion after successful upload?

[jeremyestein]

Looks sensible. A couple of minor comments. More general question: I don't think this deletes the temporary archives, so at some point we'll have to do a disk clean up of them. Should we implement temporary archive deletion after successful upload?

No, it doesn't delete them yet. I think to start with, keeping them will be useful for debugging, but I hope as part of #77 we will get some sort of deletion policy going.