Repository navigation
feat: offer the power tailgate command to every car - #524
Merged
Merged
Conversation
Nothing in the vehicle data tells which cars have a power tailgate: the MG S6 EV has one but no CTRLBOOT or UB code in its model configuration, the same as an MG4 with a manual boot. Drop POWER_TAILGATE_VINS. The command is sent to every car, and the Home Assistant cover is published for every car but disabled by default. Cars without a power tailgate are expected to refuse the command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #523. Drops the
POWER_TAILGATE_VINSopt-in, which hasn't been released yet.Why
Nothing in the vehicle data tells which cars have a power tailgate:
CTRLBOOTorUB(see Ventilated front seats control saic-python-client-ng#35).CTRLBOOTis the electric tailgate code andUBthe tailgate unlock code. Both are absent on the S6, so the app must decide some other way, which hasn't been found.Changes
doors/boot/powerTailgate/setis handled for every car. Cars without a power tailgate are expected to refuse it, and the result topic then reports the error.enabled_by_default: false. Enable it in HA to use it.--power-tailgate-vins/POWER_TAILGATE_VINS,VehicleInfo.has_power_tailgateand their tests. Updated the README.