Repository navigation
feat: hint at BATTERY_CAPACITY_MAPPING for the ambiguous MG4 Urban pack size - #535
Merged
Merged
Conversation
…ck size The AH4EM series is sold with 43 kWh and 54 kWh packs and the series does not tell them apart. Keep the defaults, log a one-time hint and document the override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MG4 Urban (
AH4EM*) is sold with 43 kWh and 54 kWh packs, and the series suffix does not tell them apart (see #526, #452, #455).BATTERY_CAPACITY_MAPPINGsyntax for its VIN.Refs #526 (does not close it: a real discriminator is still needed).