Improve PWA routing, performance, and remote sync#338
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/appand deep links reliable through the hosted app rewrite and root-scoped, route-filtered service workerRoot cause
The public
/appalias only covered the entry route, the worker scope/cache lifecycle did not reliably own deep links or loaded chunks, and remote snapshots/reconnects could replay stale cursors or transfer unbounded transcript history. The mobile build also eagerly pulled heavy feature chunks into disconnected startup.Validation
pnpm run typecheckpnpm run lintpnpm run fmt:checkpnpm run test— 5,746 passedpnpm run test:perf:remote— 6,006 frames in 17 ms/appbrowser test — online reload 188 ms; offline reload 701 ms; 112/112 cache hits