🔧 chore: bump version to 3.43.2 and update weight retrieval logic - #427
Conversation
TheBjoRedCraft
commented
Sep 12, 2026
- update version in gradle.properties from 3.43.1 to 3.43.2
- modify weight retrieval in LuckPermsAccess.kt to use getOrNull() for safety
- update version in gradle.properties from 3.43.1 to 3.43.2 - modify weight retrieval in LuckPermsAccess.kt to use getOrNull() for safety
There was a problem hiding this comment.
🟡 Changes recommended
A new public top-level OptionalInt.getOrNull() extension is introduced but only used locally, unnecessarily expanding the exposed API surface.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR bumps the project version and adjusts LuckPerms group weight access to safely handle absent weights (via OptionalInt → nullable → default fallback), reducing the chance of runtime issues when a group has no configured weight.
Changes:
- Bump
versioningradle.propertiesfrom3.43.1to3.43.2. - Update
User.weightto use a safeOptionalIntunwrap (getOrNull()+?: 0) when reading group weight. - Add an
OptionalInt.getOrNull()helper and reformatgetLuckPermsUserOrNull()for readability.
File summaries
| File | Description |
|---|---|
| surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/luckperms/LuckPermsAccess.kt | Makes LuckPerms group-weight retrieval resilient to missing weights and adds an OptionalInt helper used by the new logic. |
| gradle.properties | Updates project version to 3.43.2. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |
twisti-dev
left a comment
There was a problem hiding this comment.
Und der abi dump muss aktualisiert werden
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |