Skip to content

🔧 chore: bump version to 3.43.2 and update weight retrieval logic - #427

Merged
twisti-dev merged 4 commits into
version/26.2from
fix/fix-weight-get-in-luckperms-access
Sep 15, 2026
Merged

twisti-dev merged 4 commits into
version/26.2from
fix/fix-weight-get-in-luckperms-access

Conversation

@TheBjoRedCraft

Copy link
Copy Markdown
Contributor
  • update version in gradle.properties from 3.43.1 to 3.43.2
  • modify weight retrieval in LuckPermsAccess.kt to use getOrNull() for safety

- update version in gradle.properties from 3.43.1 to 3.43.2
- modify weight retrieval in LuckPermsAccess.kt to use getOrNull() for safety
@TheBjoRedCraft TheBjoRedCraft self-assigned this Sep 12, 2026
Copilot AI lite review requested due to automatic review settings September 12, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A new public top-level OptionalInt.getOrNull() extension is introduced but only used locally, unnecessarily expanding the exposed API surface.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR bumps the project version and adjusts LuckPerms group weight access to safely handle absent weights (via OptionalInt → nullable → default fallback), reducing the chance of runtime issues when a group has no configured weight.

Changes:

  • Bump version in gradle.properties from 3.43.1 to 3.43.2.
  • Update User.weight to use a safe OptionalInt unwrap (getOrNull() + ?: 0) when reading group weight.
  • Add an OptionalInt.getOrNull() helper and reformat getLuckPermsUserOrNull() for readability.
File summaries
File Description
surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/luckperms/LuckPermsAccess.kt Makes LuckPerms group-weight retrieval resilient to missing weights and adds an OptionalInt helper used by the new logic.
gradle.properties Updates project version to 3.43.2.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ API/ABI changes detected!

This PR contains changes that modified the public API. To update the reference ABI dumps:

./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git push

After updating, the CI will pass. Make sure the changes are backward compatible.

@twisti-dev twisti-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Und der abi dump muss aktualisiert werden

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ API/ABI changes detected!

This PR contains changes that modified the public API. To update the reference ABI dumps:

./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git push

After updating, the CI will pass. Make sure the changes are backward compatible.

@twisti-dev
twisti-dev added this pull request to the merge queue Sep 15, 2026
@twisti-dev
twisti-dev removed this pull request from the merge queue due to a manual request Sep 15, 2026
@twisti-dev
twisti-dev merged commit 10982ff into version/26.2 Sep 15, 2026
7 checks passed
@twisti-dev
twisti-dev deleted the fix/fix-weight-get-in-luckperms-access branch September 15, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants