Skip to content

ci: modernize GitHub Actions and Node setup - #346

Merged
SMAKSS merged 5 commits into
developfrom
ci/modernize-github-actions
Nov 3, 2026
Merged

SMAKSS merged 5 commits into
developfrom
ci/modernize-github-actions

Conversation

@SMAKSS

@SMAKSS SMAKSS commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Pin checkout v7.0.1, pnpm/setup v3.0.0, and upload-artifact v7.0.2 by commit SHA.
  • Set Node 26 through .nvmrc and pnpm 12.17.0 through packageManager.
  • Use pnpm/setup for Node, pnpm, and lockfile-required installation.
  • Explicitly deny esbuild's install script with allowBuilds: { esbuild: false }, preserving the prior install-script policy.
  • Remove npm registry configuration that can conflict with trusted publishing and remove the redundant global npm upgrade; the Node 26 runtime provides a sufficiently recent npm.
  • Run the existing test script and make pnpm audit findings fail CI.
  • Update vulnerable Vite/Vitest dependencies and transitive packages; the final pnpm audit reports zero advisories.
  • Preserve the existing master and develop release channels.

Validation

  • pnpm 12.17.0 lockfile update passed supply-chain verification.
  • pnpm audit --audit-level moderate reports no known vulnerabilities.
  • Formatting and git diff --check passed.
  • PR CI on cb91720 passed.

Copilot AI balanced review requested due to automatic review settings November 3, 2026 03:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The audit gate fails on a vulnerable dependency, the release workflow may use the wrong npm version, and the pnpm upgrade leaves an incompatible workspace setting that blocks clean installs.

3 open issues
1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Modernizes CI and publishing for @smakss/react-scroll-direction while preserving the master and develop release channels.

Changes:

  • Pins GitHub Actions by commit SHA and consolidates runtime setup and dependency installation through pnpm/setup.
  • Selects Node 26 and pnpm 12.17.0, adding package-manager entries to the lockfile.
  • Adds tests and a blocking security audit to CI, and removes registry configuration from publishing setup.
File Description
pnpm-lock.yaml Adds pinned pnpm binaries and package-manager metadata.
package.json Declares pnpm 12.17.0 as the package manager.
.nvmrc Changes the Node version to 26.
.github/​workflows/​npm-publish.yml Consolidates setup and removes registry configuration while retaining release channels.
.github/​workflows/​ci.yml Pins actions, consolidates setup, runs tests, and makes audit findings fail CI.

Review effort: Balanced

Comment thread .github/workflows/ci.yml Resolved
Comment thread .github/workflows/npm-publish.yml Resolved
Comment thread package.json Resolved
Copilot AI balanced review requested due to automatic review settings November 3, 2026 03:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The blocking audit fails on vulnerable dependencies in the committed lockfile, and the release workflow may use an older npm that cannot support trusted publishing.

3 open issues
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

@SMAKSS
SMAKSS merged commit 654c1cb into develop Nov 3, 2026
2 checks passed
@SMAKSS
SMAKSS deleted the ci/modernize-github-actions branch November 3, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants