fix: adding in run_id injection#5893
Open
cmgoffena13 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Collaborator
|
Looks good to me. The new Optional follow-up: add BigQuery-specific coverage too, since BigQuery also exposes correlation IDs as job labels and there is already similar coverage for plan_id labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding in run_id injection to the run command, similar to how plan_id is injected into queries. Identifies SQLMesh triggered queries.
Test Plan
Added in test similar to the plan_id injection test ("test_plan_evaluator_correlation_id")
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO