Repository navigation
Conversation
Signed-off-by: perjmi <perjmi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rendering virtual properties and
ON_VIRTUAL_UPDATEstatements rebuilds and normalizes the full snapshot table mapping for each model during promotion. Prepare the physical mapping and environment overrides once per promotion, share its normalized keys across workers, and give table replacement only the entries referenced by each expression.Preserve representative-snapshot selection, override precedence, macro table resolution, and embedded-model expansion. Embedded-model scans remain unchanged.
Refs #6018.
Test Plan
python -m pytest tests/core/test_snapshot_evaluator.py tests/core/test_model.py: 514 passed.make style: passed, including Ruff, mypy, and migration validation.make fast-test: all four phases passed (2,668 fast, 5 isolated, 1 registry isolation, and 190 dialect isolation test executions), using Python 3.11.15, four workers, the declared development dependencies, and an isolated UnixODBC runtime.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO