bufio: Fix splice counters on partial writes - #110
Merged
Merged
Conversation
nekohasekai
changed the title
nekohasekai
force-pushed
the
splice-count-partial-writes
branch
from
September 20, 2026 03:14
899a1a8 to
39db160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Linux splice copy fails after a partial write, the current round's bytes are omitted from the counters and the returned byte count.
Count source reads when data enters the pipe, and count bytes written to the destination before returning a write error. The return value tracks bytes written.
Validation: Linux
go test ./...andmake lintfor all five configured platforms pass. The new Linux socket-pair regression test fails on the old implementation and passes with the fix.go vet ./...reports the same three existing diagnostics with the unmodifiedmainimplementation.