Skip to content

Remove ModuleDefinition parameters from ContextToTypeSignature - #599

Merged
SamboyCoding merged 2 commits into
SamboyCoding:developmentfrom
AssetRipper:remove-module-parameter
Aug 10, 2026
Merged

Remove ModuleDefinition parameters from ContextToTypeSignature#599
SamboyCoding merged 2 commits into
SamboyCoding:developmentfrom
AssetRipper:remove-module-parameter

Conversation

@ds5678

@ds5678 ds5678 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

coveralls commented Aug 9, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 31341698361

Coverage decreased (-0.01%) to 29.151%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: 54 uncovered changes across 5 files (44 of 98 lines covered, 44.9%).
  • 3 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
Cpp2IL.Core/Utils/AsmResolver/AsmResolverAssemblyPopulator.cs 38 15 39.47%
Cpp2IL.Core/IlGenerator.cs 21 2 9.52%
Cpp2IL.Core/Utils/AsmResolver/ContextToTypeSignature.cs 29 22 75.86%
Cpp2IL.Core/Utils/AsmResolver/ContextToFieldDescriptor.cs 4 0 0.0%
Cpp2IL.Core/Utils/AsmResolver/ContextToMethodDescriptor.cs 6 5 83.33%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
Cpp2IL.Core/Utils/AsmResolver/ContextToTypeSignature.cs 2 60.71%
Cpp2IL.Core/Utils/AsmResolver/AsmResolverAssemblyPopulator.cs 1 56.3%

Coverage Stats

Coverage Status
Relevant Lines: 16360
Covered Lines: 5511
Line Coverage: 33.69%
Relevant Branches: 12939
Covered Branches: 3030
Branch Coverage: 23.42%
Branches in Coverage %: Yes
Coverage Strength: 139735.22 hits per line

💛 - Coveralls

@ds5678
ds5678 force-pushed the remove-module-parameter branch from 25ed047 to a3980fa Compare August 9, 2026 19:47
@ds5678
ds5678 force-pushed the remove-module-parameter branch from a3980fa to 06032b2 Compare August 9, 2026 22:13
@SamboyCoding
SamboyCoding merged commit 0098bae into SamboyCoding:development Aug 10, 2026
9 checks passed
@ds5678
ds5678 deleted the remove-module-parameter branch August 10, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants