fix: Fix DB configuration in docker-compose file - #920
Open
t-naumenko wants to merge 2 commits into
Open
t-naumenko wants to merge 2 commits into
t-naumenko wants to merge 2 commits into
Conversation
Signed-off-by: Tetiana Naumenko <t.naumenko@samsung.com>
t-naumenko
requested review from
MoonkiHong,
o-kopysov,
tdrozdovsky and
tiokim
as code owners
September 9, 2026 22:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
=========================================
Coverage 93.67% 93.67%
Complexity 427 427
=========================================
Files 30 30
Lines 1801 1801
Branches 233 233
=========================================
Hits 1687 1687
Misses 49 49
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Tetiana Naumenko <t.naumenko@samsung.com>
o-kopysov
approved these changes
Sep 10, 2026
o-kopysov
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
We need to re-generate documentation after merging PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes an insecure default database configuration in the shipped Docker Compose
deployments.
docker-compose.ymlanddocker-compose-quick.ymlstarted MySQLas
rootwith an empty password and published port3306to the host(
docker-compose-quick.ymladditionally setMYSQL_ALLOW_EMPTY_PASSWORD=yes).Since these are the documented quick-start deployment path, anyone able to
reach the published port could connect to the database as
rootwithoutcredentials and read/write all LPVS data.
CVSS 3.1: AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:L
CWE-1392 (Use of Default Credentials), CWE-258 (Empty Password in
Configuration File), CWE-16 (Configuration), CWE-668 (Exposure of Resource to
Wrong Sphere)
Fixes # (issue)
Type of change
Testing
Verified manually with
docker compose(Docker Compose v2), against bothdocker-compose.ymlanddocker-compose-quick.yml:docker compose configwith no.envpresent fails immediately with theSet MYSQL_ROOT_PASSWORD in .env ...error, instead of silently starting with empty credentials..envpopulated,docker compose up -d mysqldbinitializes cleanly with no permission errors.lpvsuser and confirmed it has exactly the privileges the app needs:SHOW TABLES, plusALTER TABLE(covers Hibernate'sddl-auto=updateschema updates) succeed against thelpvsschema.lsof/docker network inspectthat port 3306 is no longer reachable from the host and the network holds no stray endpoints afterdocker compose down.spring.datasource/database_dump.sql/Hibernate config do not require any privilege beyond standard DDL/DML on thelpvsschema (noGRANT/CREATE USER/system-schema access anywhere in the codebase), so the least-privilege user is sufficient for both the regular and quick-start scenarios (they share the samelpvs/mysqldbservice definitions —docker-compose-quick.ymlonly adds anngroktunnel on top)Test Configuration:
Checklist: