Repository navigation
Support secure LAN agent links over SSH - #21
Open
ScriptedAlchemy wants to merge 4 commits into
Open
ScriptedAlchemy wants to merge 4 commits into
ScriptedAlchemy wants to merge 4 commits into
Conversation
|
Keep SSH descriptions passive until link approval, then bootstrap only the approved connection. Carry the identity-verified HTTP endpoint through OAuth sign-in while retaining the durable SSH route for reconnection. Add regression coverage for approval gating, bootstrap timing, and endpoint consistency. Validated with the required changed-file gate: 63 tests across 6 files and typechecks for 10 packages.
- Reject SSH link hosts with shell characters; ssh_config expands %h into ProxyCommand and Match exec shells. - Reuse the CLI install.sh actually installs (PATH or ~/.local/bin), after the exact pinned runtime, instead of the unused ~/.t3/bin. - Only reuse a tunnel while its ssh process is still running, so a process that took over the freed port never receives link tokens. - Include the underlying cause in the SSH link error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Agent links could not use SSH addresses for encrypted LAN access, and connection failures gave little guidance about macOS Local Network permissions. Remote bootstrap also attempted to download preview archives even when a compatible CLI was already installed.
Add
ssh://user@host[:port]agent links using managed, loopback-bound SSH tunnels. Preserve peer identity and access-limit checks, reconnect through the saved SSH route, and leave the remote server and active jobs running when disconnecting. Reuse a compatible installed CLI before downloading an archive, filter unsafe addresses from agent-link pickers, and improve desktop/mobile connection guidance and documentation.Validation
vp run check:changedpassed: 63 tests across 6 files, typechecks for 10 affected packages, formatting, lint, both knip checks, GraphQL generation, and native project-memory addon build.Review follow-up keeps remote SSH bootstrap behind explicit link approval and carries the verified HTTP endpoint through sign-in, while preserving the durable SSH route for reconnect.
Review fixes implemented and verified with GPT-6 Astra Pro in the Codex harness.