test(mcp): prove tracedecay_configuration_protected_preview behavior - #1615
ScriptedAlchemy wants to merge 11 commits into
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…ted-preview-559b Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Review (as part of the 2026-09-18 PR sweep): not merging in this form. The journey test itself is well built, but the PR bundles:
Suggested path: resubmit as two PRs off current |
Summary
tracedecay_configuration_protected_previewthrough the production MCPtools/callpath.codexis absent, and the delivery credential-gate case.Motivation
Callers of this tool need a dry-run that names the submitted change without leaking the protected value, and a typed refusal when the CAS revision or the change itself is not admissible.
The previous head's CI was red for reasons that also fail on
origin/master: unformattedmatchchains, a rustdoc list that starts with a comma, a prepare test that demandedReadywhen the Codex CLI is missing, and a credential-gate assertion that searched for lowercaseconfigure.Changes
crates/tracedecay/src/daemon/production_harness/configuration_protected_preview_journey_test.rsdrives the preview tool the way a host does.lifecycle_lease.rsand the generation-store lock, the privacy RE2 doc comment, the Codex prepare expectation, and the delivery-gate phraseConfigure a token.Test plan
scripts/require-exact-test.sh cargo test -p tracedecay --lib daemon::production_harness::configuration_protected_preview_journey_test::protected_preview_redacts_the_change_and_refuses_stale_or_invalid_input -- --exact—1 passed; 0 failedin 1.67scargo fmt --all -- --checkcargo clippy -p tracedecay-privacy --lib -- -D warnings1 passedeachorigin/masterthe same way. Those assertions were not loosened.Checklist
CHANGELOG.mdupdated (under[Unreleased]if no version bump).envfiles included