test(ci): close three master-tip readiness races - #1794
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Heads-up from the master-repair sweep: the three races this PR closes landed on master today via #1792, so this branch now conflicts with master on all three files and its CI run 35421292205 is red on the old base:
One idea here is worth keeping: killing the daemon's process group so helper children cannot hold the listener fd. If you want it, it composes with the bounded wait; happy to fold it into the next fix PR (#1797) rather than rebase this one. |
6985dea to
37d6bc0
Compare
advisory_runtime_acceptance.rs keeps #1794's deadline-bounded wait for a durable Codex stop terminal (committed or exact_duplicate), which already carries #1838's assertion; #1838's production change (admission-owned commit status) merged cleanly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
HTTP reset checks ride out a still-warming project open instead of treating the first after_delay answer as the terminal. Ignored-dependency publication faults a pointer a background pass cannot rename over. Killing a test daemon now signals its process group, and the next spawn waits out a socket that is still closing. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
The nested reconciling if trips clippy::collapsible_if under -D warnings. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
A completed accepted_for_replay is not a durable commit. Keep polling until committed or exact_duplicate, or the deadline fails closed. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Master's coalesced_publication_failure fix (0d328fa) takes the generation-store lock before corrupting the active pointer, and its own comment records why the background admission permit is not the proof: the racer releases that permit before it finishes attaching the generation's text artifact, so holding it does not mean the store is quiet. Being granted the store lock does. The extra permit hold this branch layered on top adds a second 5s spin for a race the landed fix already closes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
8715742 to
30dbeba
Compare
Fold master tip including #1855, #1857, #1794, and #1795 into the batch while keeping folded PR ancestry. # Conflicts: # crates/tracedecay/tests/common/mod.rs # crates/tracedecay/tests/mcp_suite/git_correlation_test.rs # crates/tracedecay/tests/mcp_suite/mcp_handler_test.rs Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Summary
Rebased onto green master tip
9520d75f3612016653d90f667c57bd5a7514e454(42 commits). Head is30dbebab5e9f8c6600a0e2afdb48b71b2fe81556..github/workflows/ci.ymlis untouched: nopull_requesttrigger, hotpath stays crates.io.unavailable/after_delay/pre_admission) for the same 15s grace the CLI already uses, then assertreset_required.accepted_for_replay; onlycommittedorexact_duplicateproves the transcript.flight_tests.rsmatches master.Test plan
cargo clippy -p tracedecay-cli --tests --locked -- -D warningscargo clippy -p tracedecay --features test-helpers --test runtime_acceptance_suite --test daemon_suite --locked -- -D warningscargo clippy -p tracedecay --features test-transport --test transport_acceptance_suite --locked -- -D warningscli_non_interactive_test::branch_search_serves_a_committed_generation_behind_dirty_worktree_state— 1 passedadvisory_runtime_acceptance::packaged_host_ingest_delivers_a_registered_advisory_cycle— 1 passedcode_index_ignored_dependencies_test::flight_tests::coalesced_publication_failure_preserves_the_scheduler_error_family— 1 passedtyped_terminal_restart_acceptance::transport_boundaries::reset_required_survives_http_mcp_and_rust_sdk_across_restart— 1 passedCI(workflow_dispatch) on30dbebab5e9f8c6600a0e2afdb48b71b2fe81556.Checklist
.envfiles includedCHANGELOG.mdupdated (test harness only; no user-facing change)