Skip to content

fix(code-index): keep clone copy off the freshness receipt - #1825

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
cursor/graph-rebuild-timeout-1bd2
Sep 19, 2026
Merged

ScriptedAlchemy merged 1 commit into
masterfrom
cursor/graph-rebuild-timeout-1bd2

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Rebased onto master e1300458e4333902b37cd6772e9e5742e0ac885e (fix(sessions): drop the u64 identity conversion clippy rejects #1858). The serving delta is unchanged.
  • The publication advance that installs exact and lexical owners no longer copies the prior lexical artifact into the clone successor.
  • Freshness can become current once those owners and the graph seat are ready. Clone backfill stays pending and runs on the retained driver after the seat, outside reconcile_in_progress.
  • Pairs with fix(code-index): keep sealed generation when freshness proof expires #1818 (c1633dd96bb0f70d89d5a33cc64c3d5c35d71dfa). No file overlap. Neither PR subsumes the other.
  • RECEIPT_TIMEOUT is unchanged. This does not touch ci.yml.

Dispatch SHA: 76c58af7e25dde6daa330bab74af5ee281d98c61

Clippy on runs 35442002957 / 35442004499 failed in tracedecay-sessions (u64::try_from of Metadata::len) before this crate was checked. That one-liner is now on master via #1858. This head does not carry a second copy. cargo clippy -p tracedecay-code-index-runtime -p tracedecay-sessions --all-targets --locked -- -D warnings passed on the serving tree this head still has.

Test plan

  • lexical_readiness_leaves_the_clone_successor_uncopied and four neighbors — 5 passed. successor filter — 10 passed. Serving sources are byte-identical to that run after this rebase.
  • cursor_cas_lost_on_a_partially_covered_window_replays_the_tail — 1 passed on the length line fix(sessions): drop the u64 identity conversion clippy rejects #1858 landed.

Checklist

  • CHANGELOG.md updated (under [Unreleased] if no version bump)
  • No secrets, credentials, or .env files included
  • Breaking changes documented (if any) — none
Open in Web Open in Cursor 

@changeset-bot

changeset-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 76c58af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy marked this pull request as ready for review September 19, 2026 06:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-19T06:40:50.533183Z 91c4bf9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor
cursor Bot force-pushed the cursor/graph-rebuild-timeout-1bd2 branch 2 times, most recently from b104684 to e6a9f0c Compare September 19, 2026 12:06
The advance that installs exact and lexical owners also copied the
prior lexical artifact into the clone successor. That copy ran under
reconcile_in_progress, so status stayed non-current for the copy.
Leave the successor pending; the retained driver starts it after the
seat.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/graph-rebuild-timeout-1bd2 branch from e6a9f0c to 76c58af Compare September 19, 2026 14:39
@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Folded into #1848 at an earlier head; the commits this branch received afterwards are being reviewed for the next integration batch (ci/pr-batch-e). Leaving open until that batch lands.

@ScriptedAlchemy
ScriptedAlchemy merged commit 9974d83 into master Sep 19, 2026
23 of 25 checks passed
ScriptedAlchemy added a commit that referenced this pull request Sep 19, 2026
chore: integration batch E (post-fold commits of #1804, #1818, #1821, #1825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants