fix: clear the deterministic master CI failures - #1865
Conversation
The npm policy checker still required a tag trigger after publication moved to a master dispatch. An expired source proof raced the reconcile worker. Clone warmup faults that are not contract violations were a permanent search failure while a generation was retiring.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eeb1ec1d1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Err(_) => { | ||
| return unavailable( | ||
| code_search::CodeIndexSearchUnavailableReasonV1::GenerationUnverified, |
There was a problem hiding this comment.
When a similar or redundancy request is cancelled or reaches its deadline while finish_clone_similarity_warmup_for_request advances fingerprints, that function returns RetrievalPortError::Cancelled or BudgetExceeded; this catch-all now converts both into the retryable GenerationUnverified state. The executor therefore loses the requested Cancelled/TimedOut terminal outcome and clients may retry work the caller already ended, so handle those two variants before the transient catch-all, as the later query execution already does.
AGENTS.md reference: AGENTS.md:L152-L154
Useful? React with 👍 / 👎.
# Conflicts: # crates/tracedecay-code-index-runtime/src/code_index_scheduler/tests/reconcile.rs
`advance_text_serving_for_request` calls `mark_text_serving_failed` for `CapabilityManifestRejected`, `GenerationMismatch`, `IncompatibleProjection` and `Contract` (serving.rs:2589). Mapping every non-`Contract` error to `GenerationUnverified` told callers to retry a projection that the same call had just marked permanently failed, so the three incompatibility variants became an unbounded retry on a terminal state. 024364a already maps the observed retiring-staging fault (`AuthorityUnavailable`) to `generation_unverified`, and cacf79a root-caused the remaining clone-lane refusal as the head-open `Contract` violation and fixed it at source, recording that a retryable verdict would only have hidden it. No evidence names a further variant, so keep master's mapping. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The policy now forbids the `release` trigger because a run on the release tag cannot restore the previous release's Actions cache (3ac7ae1), but no test covered that rule: the suite only checked that the master dispatch is present. Re-adding `release: types: [published]` passed. Add the mirror mutation, and rename `assert_release_trigger` to `assert_master_dispatch_trigger` so the function no longer names the trigger it rejects. Verified by weakening the checker to accept `{release, workflow_dispatch}` again: the new test is the only one that fails. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Reviewed and synced onto master 140b1de (fast-forward pushes, no force):
CI dispatched on 656cca9; merging on green. |
1 participant
Summary
releasetrigger after the workflow moved to a masterworkflow_dispatch, so the policy test never mutated the file and the checker rejected the live workflow.generation_unverifiedinstead of a permanentsearch_failedwhile a generation is still retiring.Test plan
python3 scripts/test-check-sdk-publish-workflow.pypython3 scripts/check-sdk-publish-workflow.pycargo check -p tracedecay-code-index-runtime --libproduction-routerand Test Linux runtime/root-transport