Skip to content

test(mcp): take the first settled search before pinning freshness #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Sep 20, 2026
+22 −11
Merged

test(mcp): take the first settled search before pinning freshness #1891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions crates/tracedecay/tests/mcp_suite/mcp_handler_test/search_behavior_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,28 @@ async fn search_returns_the_named_symbol_and_rejects_a_missing_query() {

warm_code_index_search(&server, "ledger_post_entry").await;

let hit = handle_real_server_tool_call(
&server,
"tracedecay_search",
json!({
"query": "ledger_post_entry",
"prefer_symbol": true,
"format": "json",
}),
)
.await;
let hit: Value = serde_json::from_str(extract_real_server_text(&hit)).expect("search JSON");
// The warm-up proves the generation is current and every lane complete.
// The seat can still have a continuation pass in flight after that, and
// a search taken while it runs reports `verifying`. The literal payload
// below is the settled one, so take the first search that reports it.
let mut hit = Value::Null;
for _ in 0..40 {
let response = handle_real_server_tool_call(
&server,
"tracedecay_search",
json!({
"query": "ledger_post_entry",
"prefer_symbol": true,
"format": "json",
}),
)
.await;
hit = serde_json::from_str(extract_real_server_text(&response)).expect("search JSON");
if hit["freshness"] == json!({ "state": "fresh" }) {
break;
}
tokio::time::sleep(std::time::Duration::from_millis(250)).await;
Comment on lines +79 to +82

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retry only the expected verifying state

When the post-warm search is possibly_stale because of a real stale generation, generation mismatch, stale lane, or unavailable authority—not the expected continuation-pass verifying state—this loop silently retries until a later response becomes fresh, allowing the regression this assertion previously detected to pass. Inspect freshness.indexing.staleness_state and retry only verifying, failing immediately for other non-fresh verdicts.

AGENTS.md reference: AGENTS.md:L177-L178

Useful? React with 👍 / 👎.

}
assert_eq!(hit["freshness"], json!({ "state": "fresh" }), "{hit}");
assert_eq!(
hit["coverage"],
Expand Down
Loading