Skip to content

Validate archived MI355X MiniMax M3 vLLM disaggregation with srt-slurm - #2824

Draft
cquil11 wants to merge 1 commit into
agent/srt-slurm-amd-integrationfrom
agent/port-minimaxm3-mi355x-vllm-srt-slurm
Draft

cquil11 wants to merge 1 commit into
agent/srt-slurm-amd-integrationfrom
agent/port-minimaxm3-mi355x-vllm-srt-slurm

Conversation

@cquil11

@cquil11 cquil11 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Scope

Port MI355X archived MiniMax M3 vLLM to the shared AMD-enabled srt-slurm integration.

  • Convert the existing port recipes to native schema 2 (engine and roles) and preserve their engine, image, topology, and workload settings.
  • Keep the unchanged InferenceX benchmark_serving.py custom-benchmark interface; no engine patches.
  • Put the actual fixed-sequence concurrency lists in the master config and consume caller-owned CONC_LIST, replacing placeholder [1] rows and private recipe sweep lists where present. This preserves the existing measured points while matching current result collection.

This workload is deprecated upstream and remains in configs/deprecated/; it is not restored to active sweeps. Retained for the previously requested runtime-path coverage.

Stack

Based directly on shared AMD integration #2542, which is rebased onto InferenceX main at 96bccfe12b637dad23d32f0bf7ceef0ea86de15a. This child contains only its workload configs, schema-2 recipes, and append-only performance changelog entry. Shared launcher/profile/adapter changes live in #2542.

The base selects SemiAnalysisAI/srt-slurm 03863ab23804f8a31811d9aaccc54abc8961a41c: #1#11#7#14, synchronized with NVIDIA srt-slurm 85086d3c1fe7b319a1d0d7db8781047dd1940772. NVIDIA runners retain their existing runtime selection.

Refresh status

Offline matrix validation: 1 topology/workload rows covering 9 benchmark concurrency points; all 2 prepared throughput/eval configurations pass the pinned runtime's schema/topology checks.

No fresh E2E tests or sweeps were started or rerun. Sweep-trigger labels are removed. Historical runtime evidence is listed in the base PR and does not validate these new heads. Full GPU validation remains pending authorization; this refresh makes no new performance or merge-readiness claim.

AI model disclosure

The exact AI model/version for this refresh is not exposed by the runtime and could not be verified. No subagents contributed to this refresh; earlier model identities are not reliably recorded.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@cquil11

cquil11 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

Runtime startup now passes with the clean MoRI port-allocation fix: both allocations completed all TP handshakes, routed generation, and backend health checks on the unchanged official images.

Run 33837126410 exposed a dispatch-input mistake before evaluation began: literal eval-limit=full is passed through to lm-eval as --limit full, which is invalid. The full dataset requires the empty default for this harness. No engine, benchmark, or srt-slurm source change is needed for that error.

Corrected full throughput-plus-eval run: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/33837838363
Exact checkout: 86b6762. Runtime: 33a3d811b7956973e4ef78b1d0cf4a5d56dad6a1. All nine concurrency points; eval-limit empty. The prior throughput job is left intact as additional evidence, not combined with this run to claim full-run success. Validation remains in progress.

@cquil11

cquil11 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

The first full throughput sweep has passed: all nine concurrency points and 5,116/5,116 measured requests completed on the official vLLM v0.28.0 image. Throughput job: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/33837126410/job/100911912515

The raw artifact audit passed for unique point coverage, exact request/token totals, nonempty outputs, and finite metrics. srt-slurm completed and released the allocation without any host-repair steps.

This is not yet complete validation: that workflow still fails because of the earlier eval-limit dispatch mistake. The corrected full run remains https://github.com/SemiAnalysisAI/InferenceX/actions/runs/33837838363, with full GSM8K (empty limit) and all nine throughput points. Its eval is prioritized first in the MI355X queue. No engine patches, config workarounds, or changes to previously validated recipes have been introduced.

@cquil11

cquil11 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

Full accuracy validation is now green on the corrected run: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/33837838363/job/100913948095

  • Full GSM8K: 1,319 unique documents in each scoring filter; no evaluation limit.
  • Strict accuracy: 0.9469294920394238. Flexible accuracy: 0.9461713419257013. Both exceed the unchanged 0.90 threshold.
  • Per-sample audit: zero empty responses, unique document IDs/hashes, and recomputed averages exactly matching the native result.
  • The collected artifact agrees: n_eff=1319, infrastructure_success=true, integration_error=null, concurrency 256, TP4/TP4.

No graph-mode override, engine patch, or config workaround was needed. The same corrected workflow is now running its full nine-point throughput job (Slurm 42263), so whole-run validation is still in progress. The earlier nine-point throughput sweep also passed and was independently audited, but is not being used as a fill-in for this run.

@cquil11

cquil11 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

Complete validation is green: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/33837838363 (attempt 1).

All nine throughput points passed with 5,116/5,116 measured requests. Full GSM8K passed with 1,319 unique questions, zero empty responses, strict accuracy 0.9469294920394238, and flexible accuracy 0.9461713419257013 against the unchanged 0.90 threshold. Raw and collected artifacts were independently checked for counts, token totals, finite metrics, topology/GPU metadata, and matching scores. Both Slurm allocations completed 0:0 and released normally.

Exact tested checkout: 86b6762; srt-slurm: 33a3d811b7956973e4ef78b1d0cf4a5d56dad6a1. Official images only, no engine patches, graph-mode override, configuration workaround, or fill-in run.

The PR description now contains the complete evidence and caveats. It remains draft solely as an archived compatibility port: the regular changelog processor does not accept archived keys, and this manual e2e run is not stageable or reusable as a native PR sweep. No deprecated production sweep was re-enabled.

@cquil11
cquil11 force-pushed the agent/srt-slurm-amd-integration branch from 0d7ca6f to 6d439d6 Compare September 18, 2026 22:49
@cquil11
cquil11 force-pushed the agent/port-minimaxm3-mi355x-vllm-srt-slurm branch from 86b6762 to 1d55491 Compare September 18, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant