Repository navigation
[AgentX] MiniMax-M3.1-Flash B200 SGLang: store DSpark draft KV in FP8 / [AgentX] MiniMax-M3.1-Flash B200 SGLang:DSpark draft KV 改用 FP8 - #4598
Conversation
Set speculative-draft-kv-cache-dtype fp8_e4m3, matching the vLLM DSpark drafter, so the bf16 draft KV no longer takes HBM and HiCache host pool space from target KV. The whole curve reruns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the contribution!
中文感谢你的贡献!
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| # FP8 draft KV, as vLLM's DSpark drafter uses; bf16 costs ~10 GB of HBM per rank. | ||
| speculative-draft-kv-cache-dtype: fp8_e4m3 |
There was a problem hiding this comment.
🔴 Every point of this B200 SGLang submission now runs the DSpark draft cheaper than the pinned image's default, which CONTRIBUTING.md forbids. The override sets the draft KV to fp8_e4m3, while the PR says SGLang's drafter default is bf16. The target KV dtype stays unset. CONTRIBUTING.md:86-87 forbids "KV-cache dtype overrides aimed at the draft that lower its precision below the framework's default". Fix: drop speculative-draft-kv-cache-dtype and keep the image's default draft KV. Free HBM some other way, for example a target kv-cache-dtype that the draft inherits consistently.
Why this was flagged
The recipe base args at agentic.yaml:37 apply to every override (tp4_c1 through tp4_ep4_dram_c80), and nvidia-master.yaml:5635-5639 binds all of them for minimaxm31flash-fp4-b200-sglang-agentic-dspark. The recipe sets no target kv-cache-dtype, so only the draft's KV is quantized. That is not the "applied consistently to target and draft" allowance at CONTRIBUTING.md:60-62. On the base branch the draft KV uses the pinned image's default, bf16 per the PR's own account. After this change, all published points come from a draft run below shipped precision. CONTRIBUTING.md:100-104 says matching an upstream recipe (here, vLLM's FP8 drafter) or passing evals does not exempt this. It also says synthetic AgentX acceptance hides the hit. These throughput runs use golden synthetic AL, so the acceptance loss the PR names as a risk never shows up in the measured numbers. The codeowner Check 13 should FAIL this as a demonstrated draft-precision violation.
Verification: In agentic.yaml, line 37 of the diff adds speculative-draft-kv-cache-dtype: fp8_e4m3 under base.roles.agg.args, so all 13 overrides inherit it. No override sets a target kv-cache-dtype. The PR description says the default is bf16. So this is a draft-only override that sets precision below the framework default. CONTRIBUTING.md:86-87 forbids exactly that.
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=40739120064 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=40739120064 |
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 1 finding from earlier reviews is still open above.
Still open from earlier reviews (1):
- 🔴
inferencex-e2e/benchmarks/single_node/srt-slurm-recipes/minimaxm31flash/sglang/b200-fp4-mtp/agentic.yaml:37—Every point of this B200 SGLang submission now runs the DSpark draft cheaper than the pinned image's default, which CON…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
|
[by Claude Code] The SGLang cookbook integration of this PR's AgentX config ( This PR has no authorized |
|
[by Claude Code] sgl-project/sglang#47027 has been merged. This PR's AgentX config ( This PR has no authorized |
…sglang-agentx-fp8-draft-kv # Conflicts: # inferencex-e2e/perf-changelog.yaml
|
/use 40739120064 |
|
@zijiexia staged run 40739120064. This run remains available across future |
…sglang-agentx-fp8-draft-kv # Conflicts: # inferencex-e2e/perf-changelog.yaml
|
Ingest report — ✅ Results ingested into the Ingest workflow · Merge Ingest run · Benchmark source run
benchmarkFiles 13, rawBenchmarkRows 13, coveredByPerJobFiles 0, purgedPoints 0, failedRunRows 0, runStatsNew 0, runStatsDuplicate 0, evalSamplesNew 3957, gpuMetricSamplesNew 258696, powerPublicationPoints 13, changelogEntriesWritten 1 Counts cover only this run. Rows: benchmark_results, eval_results, agentic rows linked to a trace, gpu_metrics series. This comment updates if the ingest is rerun. 中文Ingest 报告 — ✅ 结果已写入 上表仅统计本次运行写入的数据,各行单位依次为 benchmark_results 行、eval_results 行、已关联 trace 的 agentic 行和 gpu_metrics 序列。重新运行 ingest 时本评论会原地更新。 |
The SGLang DSpark drafter stores its KV cache in bf16 by default. On B300 TP2 that took 21 GB of HBM and 71 GB of the 370 GB HiCache host pool per rank, leaving about 10% less GPU KV than vLLM, whose DSpark drafter uses FP8 KV. At high concurrency the smaller GPU cache lowered the GPU prefix hit rate and cost throughput against vLLM.
This PR sets
speculative-draft-kv-cache-dtype: fp8_e4m3in the base args of the B200 MiniMax-M3.1-Flash SGLang AgentX recipe, so the freed HBM and host memory go to target KV. The changelog entry is not append-only, so the whole curve reruns on the new recipe. The same change for B300 is in #4524.Risk: FP8 draft KV can lower real DSpark acceptance. Throughput runs use the golden synthetic AL, so the sweep's eval is what checks this.
中文
SGLang 的 DSpark drafter 默认用 bf16 存 KV cache。在 B300 TP2 上,它每个 rank 占用 21 GB HBM 和 370 GB HiCache host 池中的 71 GB,GPU KV 容量比 vLLM 少约 10%(vLLM 的 DSpark drafter 用 FP8 KV)。高并发时 GPU cache 更小,GPU prefix 命中率下降,吞吐落后于 vLLM。
本 PR 在 B200 MiniMax-M3.1-Flash SGLang AgentX recipe 的 base args 中设置
speculative-draft-kv-cache-dtype: fp8_e4m3,把省下的 HBM 和 host 内存留给 target KV。changelog 条目不是 append-only,整条曲线会用新 recipe 重跑。B300 的同样改动在 #4524。风险:FP8 draft KV 可能降低真实的 DSpark 接受率。吞吐测试使用 golden synthetic AL,因此需要由 sweep 中的 eval 来验证。
AI model disclosure
Prepared with Claude Code using
claude-opus-5-5. Reviewed by the human author before submission.🤖 Generated with Claude Code