Repository navigation
Re-pin sendspin-cpp to b0fcf5bb, #213 as merged - #101
Merged
Merged
Conversation
d961f5fb was #213's branch head. The PR merged as b0fcf5bb with the same tree, and its branch is gone, so the old pin is reachable only through an unrelated feature branch; deleting that would break every fresh configure. Also brings the roadmap's pin note up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SENDSPIN_GIT_TAGisd961f5fb, the head of sendspin-cpp#213 before it merged. #213 squash-merged asb0fcf5bband its branch was deleted.d961f5fbis now reachable only because the unrelatedchrisuthe/windows-basic-clientbranch upstream still contains it. If that branch is deleted or rewritten, every fresh configure fails to fetch the library. CI's dependency cache could hide that untilCMakeLists.txtnext changes.What
b0fcf5bb.git diff d961f5fb b0fcf5bbis empty, so the library source is identical and nothing changes in behaviour.docs/ROADMAP.mditem 3 still named90cbd808as the current pin; it now namesb0fcf5bb. The commits since then (#210, #213) touch none of item 3's gaps.Testing
Native Windows build mirroring the
windows-x86_64leg: VS 2026 clang-cl 22.1.3, Ninja, Release,-DSENDSPIN_CLI_WERROR=ON, PortAudio and mDNS on, with an emptyFETCHCONTENT_BASE_DIR, so the new SHA really was fetched.audio backends: null, stdout, portaudioandmDNS: windns (built in), matching the leg's assertions.ctest, serial: 517/517 passed. One test skips, as it always does on Windows:ASymlinkIsJudgedByWhatItPointsAt.scripts/smoke_test_windows.ps1: all 14 checks passed.scripts/package_windows.ps1: zip built and its contents assertion passed.--versionreportssendspin-cpp b0fcf5bb….