Repository navigation
Remove the deprecated pairing_window_supported config field - #216
Merged
Merged
Conversation
Deprecated and ignored since v0.9.2, with removal planned for v0.10.0. Drop the field, the deprecation-warning suppression around SendspinClientConfig that existed only for it, and its row in the integration guide.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the deprecated configuration-field cleanup.
No open issues 🎉
What changed in this PR
Removes the deprecated, ignored SendspinClientConfig::pairing_window_supported field, completing the cleanup planned in #187. Consumers still assigning it must delete those assignments; runtime behavior is unchanged.
Changes:
- Remove the field and its now-unnecessary deprecation-warning suppression.
- Remove the obsolete configuration entry from the integration guide.
| File | Description |
|---|---|
include/sendspin/config.h |
Removes the deprecated field, its comments, and warning-suppression pragmas. |
docs/integration-guide.md |
Removes the field’s configuration-table row. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
SendspinClientConfig::pairing_window_supported. The field was deprecated and ignored in v0.9.2 (#187), with removal planned for v0.10.0.Changes
[[deprecated]]attribute and doc comment.-Wdeprecated-declarationssuppression aroundSendspinClientConfig, which only existed so the struct's implicit copy and move members would not warn about this field. The struct has no other deprecated members.Breaking change
Code that still assigns
pairing_window_supportedno longer compiles. Since v0.9.2 the assignment has had no effect and has produced a deprecation warning, so the fix is to delete it. Runtime behavior is unchanged.Testing