Repository navigation
Stop Chromecast discovery when the connect times out - #309
Merged
Merged
Conversation
The timeout around the blocking Chromecast connect cannot cancel the executor thread. When cast.wait() hangs, the thread never reaches its finally block, so the zeroconf browser keeps running for the life of the process. Stop discovery from the timeout path. Co-authored-by: Paul Robertson <paularobertson@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
balloob
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When the Chromecast connect timed out, its discovery kept running for the life of the process. The timeout path now stops discovery. Minimal version of the fix by @kiwipaulrob.
Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocumentationmaintenancecidependencies🤖 Generated with Claude Code