Add a kernel test for the bundle using nyholm/symfony-bundle-test - #39
Merged
Merged
Conversation
Boots a real kernel with FrameworkBundle, TwigBundle and this bundle, and checks that the bundle's services are registered and that the is_bot() and is_bot_request() Twig functions work through the container.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage 60.00% 60.00%
Complexity 13 13
=========================================
Files 5 5
Lines 90 90
=========================================
Hits 54 54
Misses 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/SetonoBotDetectionBundleTest.php, a kernel test built with nyholm/symfony-bundle-test. It boots a real kernel with FrameworkBundle, TwigBundle and this bundle, and checks:is_bot()andis_bot_request()work through the container's realtwigservice, with a bot request on the request stack. The existing tests cover the extension and the service definitions only in isolation.New dev dependencies:
nyholm/symfony-bundle-test^3.1, the first version that supports Symfony 8symfony/framework-bundleandsymfony/twig-bundle, which the test uses directly, so the dependency analyser needs them declaredTest plan
Run locally:
With lowest dependencies, the run also shows Twig's known PHPUnit deprecations and skipped legacy test. With Symfony 8.0 at lowest versions it additionally prints 7 PHP deprecations from old Symfony package versions installed alongside it. None of them fail the build.