Let Dependabot watch facebook/php-business-sdk - #22
Merged
Merged
Conversation
The Graph API version the client talks to is ApiConfig::APIVersion from facebook/php-business-sdk, and Meta ships a new major of that package for every Graph API version, roughly three times a year. Until the constraint is widened, users of this library stay capped at the previous Graph API version, and so far somebody had to notice the release by hand. Dependabot now opens a PR that widens the constraint when a new major is released. It watches 2.x, which is now the default branch and therefore where Dependabot reads its config from. No composer.lock is committed, so releases inside the allowed range produce no PR. Other dependencies are left out on purpose: their ranges already float, and the dev tools are held on the majors that still support PHP 8.1. CLAUDE.md is updated for 2.x being the default branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #21. The Dependabot config lives on
2.xonly, and2.xis now the repository's default branch, which is where Dependabot reads its config from.The Graph API version the client talks to is
ApiConfig::APIVersionfrom whateverfacebook/php-business-sdkis installed, so the constraint^25.0 || ^26.0caps users at Graph API v26. Meta ships a new major of that package every four to five months:Until now somebody had to notice the release by hand (#10) and open a PR like #12. This adds
.github/dependabot.ymlso that PR is opened automatically.How it is set up
allowrule. The ranges of the other dependencies already float, and the dev tools are deliberately held on the majors that still support PHP 8.1, so watching them would only produce proposals that go against that policy.versioning-strategy: widen, so^25.0 || ^26.0becomes^25.0 || ^26.0 || ^27.0, the same edit as Allow facebook/php-business-sdk ^26.0 (Graph API v26.0) #12.composer.lockis committed, so a release inside the allowed range produces nothing; only a new major does.2.xonly. One entry, notarget-branch.1.xis not watched; if that is wanted later, it is one more entry withtarget-branch: "1.x".dependencies.What a Dependabot PR still needs from a human
ApiConfig::APIVersion, and the characterization tests pin the normalized and hashed output, so a behaviour change in the SDK'sNormalizerorUtil::hash()fails thehighestjobs.LiveClientTestdoes not run in CI, so one live run against the new major before tagging stays manual. CLAUDE.md now says so.^25.0once Graph API v25 is retired remains a manual decision.Also in this PR
CLAUDE.md's Branches section said
1.xwas the default branch. It now describes2.xas the default, notes thatCloses #…therefore only auto-closes issues for merges into2.x, and says that default-branch-only config lives on2.x.Test plan
dependencieslabel exists