Repository navigation
Hold msw 3 until the vitest family moves - #802
Merged
Merged
Conversation
msw 3 needs vitest 5 (the @vitest/mocker peer range of vitest 4 stops at msw 2), and it matches requests to handlers asynchronously. With vitest 5, WorkflowEditorPage passes on msw 2 and fails two or three tests per run on msw 3, so this is a migration and not a bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holds msw 3 in Dependabot until the vitest family moves. #566 cannot be merged as it is.
@vitest/mocker4.x declaresmsw: ^2.4.9, sonpm cifails on chore(deps-dev): bump msw from 2.15.0 to 3.0.3 in /src/nodepilot-ui #566 (Missing: msw@2.15.0 from lock file). Only vitest 5 accepts msw 3, and vitest 5 is already held in this file.onUnhandledRequest→onUnhandledFramerename. msw 3 now matches requests to handlers asynchronously, so a test that acts on the first render or ends with a request in flight sees state from the wrong moment. I fixed three of these cases in FailureCauses, ExecutionsPage and AuditLogPage. WorkflowEditorPage still fails two or three tests per run, and the set changes between runs. With vitest 5 and msw 2 the same file passes 133/133 twice.That makes msw 3 a migration of the timing-sensitive designer tests, not a bump. The ignore entry records this next to the existing vitest note.
🤖 Generated with Claude Code