Skip to content

Run the blocking parts of the rotation race test on dedicated threads #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sev7eNup merged 1 commit into from
Nov 5, 2026
Merged

Run the blocking parts of the rotation race test on dedicated threads #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/NodePilot.Api.Tests/Configuration/RuntimeOverridesSecretRotationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,14 @@ public async Task Rotation_ConcurrentSettingsSaveWaits_ThenUsesResealedDocumentA
return _old.Unprotect(bytes);
});
protector.Setup(x => x.Protect(It.IsAny<string>())).Returns((string value) => _current.Protect(value));
var rotation = Task.Run(() => _writer.ReencryptSecrets(protector.Object, CancellationToken.None));
// Both parts block on purpose, so they get dedicated threads instead of waiting for the
// thread pool to grow under a parallel test run.
var rotation = RunOnDedicatedThread(() => _writer.ReencryptSecrets(protector.Object, CancellationToken.None));
Task? save = null;
try
{
entered.Wait(TimeSpan.FromSeconds(10)).Should().BeTrue();
save = Task.Run(() => { saveStarted.Set(); _writer.MutateAndWrite(root => root["Unrelated"] = 99); });
save = RunOnDedicatedThread(() => { saveStarted.Set(); _writer.MutateAndWrite(root => root["Unrelated"] = 99); });
saveStarted.Wait(TimeSpan.FromSeconds(10)).Should().BeTrue();
resume.Set();
(await rotation.WaitAsync(TimeSpan.FromSeconds(10))).Skipped.Should().Be(0);
Expand All @@ -122,6 +124,12 @@ public async Task Rotation_ConcurrentSettingsSaveWaits_ThenUsesResealedDocumentA
}
}

private static Task<T> RunOnDedicatedThread<T>(Func<T> work) =>
Task.Factory.StartNew(work, CancellationToken.None, TaskCreationOptions.LongRunning, TaskScheduler.Default);

private static Task RunOnDedicatedThread(Action work) =>
Task.Factory.StartNew(work, CancellationToken.None, TaskCreationOptions.LongRunning, TaskScheduler.Default);

private string Encrypt(string value) => EncryptingJsonConfigurationProvider.EncryptForPersist(value, _old);
private string Decrypt(string value) => _current.Unprotect(Convert.FromBase64String(
value[EncryptingJsonConfigurationProvider.EncryptedValuePrefix.Length..]));
Expand Down
Loading