Repository navigation
Fix read-only editor mutations and repeated permission queries - #813
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Read-only workflows still allowed annotation changes that marked the draft dirty and triggered a rejected autosave. Note and group editing now follow the edit lock, while group collapse stays available as a local viewing choice. Save and publish also check current write access before sending queued work.
Folder and workflow lists now share permission data within each request instead of querying grants for every folder. Access rules, inheritance, authority-scoped group matching and cache invalidation are preserved. In the controller test with 100 visible folders, database reads fall from 105 to 5.
Fixes #584.
Fixes #576.
How
UnreleasedinCHANGELOG.md.Testing
WorkflowEditorPage,useWorkflowPersistenceanduseDisplayedGraph.git diff --check.The query-count comparison uses SQLite in memory; its timings are not a production benchmark. Full suites, coverage and E2E run in CI. No API/schema changes, new dependencies or UI strings.