Repository navigation
docs: 📝 Say which parts of a PR the maintainer checks by eye - #228
Merged
Merged
Conversation
Reviews were done almost entirely by Claude Code, so the maintainer lost track of the project's state. Each PR is now classified by type, and the review report starts with the places the maintainer checks. For shared components, the smoke tests don't catch a change in behavior, so the review shows the last frames on main and the PR side by side. After a merge, the review says what changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/pr-review/references/review-scope.md: PR types (A minor, B new algorithm, C shared components, D book text, E design or scope) and what the maintainer checks by eye for eachpr-reviewnow classifies each PR, starts its report with the places the maintainer checks, shows the last frames onmainand the PR side by side for type C, and says what changed in the project after a mergeWhy
Reviews were done almost entirely by Claude Code, which made it hard for the maintainer to keep track of the project's state. The automated review keeps doing what can be checked by running or against the conventions; the maintainer checks what decides the project's direction and content.
The last-frame comparison is a stopgap until #174 adds scenario tests and the contact sheet.
🤖 Generated with Claude Code