Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .claude/skills/pr-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Reviews a pull request against this project's conventions and its purpose as lea

1. Get the PR body, commits and changed files (`gh pr view <number> --json body,commits,files,headRefOid`), and read the linked issue to see what was agreed with the maintainer
2. If the PR is stacked on other open PRs, review only the commits of this step (`git show <sha>`), since earlier steps are reviewed in their own PRs
3. If the body has images or videos (`https://github.com/user-attachments/assets/...` or `![...](...)`), tell the user they need to check them in the browser
3. If the body has images or videos (`https://github.com/user-attachments/assets/...` or `![...](...)`), tell the user they need to check them in the browser. If a type B or C PR (step 5) has none, ask for them in the draft, except in PRs opened before the PR template was added (2026-11-14)
4. When reviewing as the maintainer, if the PR has no label, assignee or reviewer yet, set the missing ones with `gh pr edit <number> --add-label <label> --add-assignee <author> --add-reviewer ShisatoYano`. Pick one type label from the main change (`bug`, `enhancement` or `documentation`), and assign the PR's author, since they are the one who addresses the review. For the maintainer's own PR, skip the reviewer (GitHub doesn't allow requesting the author)
5. Classify the PR with `references/review-scope.md`, and note the places the maintainer checks by eye (file:line, GIF)

Expand All @@ -43,7 +43,8 @@ Reviews a pull request against this project's conventions and its purpose as lea

1. Write the draft in English, starting with thanks and good points, then numbered requests and suggestions
2. Keep each item short: the problem, the measured impact, and the suggested fix
3. Show the user the PR's type and the places they check by eye first, then the Japanese summary of findings and the English draft, and remind them that posting and approving are theirs to do
3. Compare the PR's images with the local results, and report a mismatch as a finding, since the images may come from an older commit
4. Show the user the PR's type and the places they check by eye first, then the Japanese summary of findings and the English draft, and remind them that posting and approving are theirs to do. When the PR has no images, open the ones made locally with `xdg-open` so the user doesn't have to look for them

## Re-review

Expand Down
12 changes: 12 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
## Summary
<!-- What does this PR change, and which issue does it close? (e.g. Closes #123) -->

## How I checked it works
<!-- Tests you ran, and what you looked at. -->

## Images
<!-- Paste images or GIFs here (drag and drop) so the reviewer can see the result without running the code:
- New simulation: its demo GIF
- Change to code under src/components/: the last frame of one or two simulations that use it, before and after your change
- Book text: a screenshot of the changed part of the built page (optional)
- Docs, comments or tests only: not needed -->
3 changes: 2 additions & 1 deletion HOWTOCONTRIBUTE.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,11 @@ python src/simulations/path_tracking/mppi_path_tracking/mppi_path_tracking.py --
The option saves the GIF at the path defined by the simulation. Without it, existing GIF paths are not overwritten and the animation is displayed instead.

### Step 4: Submit a pull request and modify code based on review
If your sample program and test were ready, let's create a pull request and submit it. When you create the PR, please write a description about the following items.
If your sample program and test were ready, let's create a pull request and submit it. The description starts with a template; please fill in the following items.

* The overview of your PR.
* How did you confirm that your program works well.
* Images or GIFs that show the result, so the reviewer can see it without running the code: the demo GIF of a new simulation, or for a change to code under `src/components/`, the last frame of one or two simulations that use it, before and after your change. Drag and drop them into the description.

After you submitted your PR, each unit tests is executed automatically by GitHub Actions. If an error occurred and unit tests failed, please investigate the reason and fix it. After all tests passed and any problems were not found by code review, I will allow you to merge your PR into main branch.

Expand Down
Loading