Repository navigation
Localization: pass gif_name to GlobalXYVisualizer - #232
Open
DeviousCardi wants to merge 1 commit into
Open
DeviousCardi wants to merge 1 commit into
DeviousCardi wants to merge 1 commit into
Conversation
Owner
|
Thank you, @DeviousCardi, for taking the first category of #231! The change is exactly what the issue asked for: the existing GIF names, no regenerated GIFs, and a clear PR description. I checked it locally: the five tests pass, One request before merging:
🤖 Generated with Claude Code |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #231 (Localization category).
Passes each localization simulation's committed GIF path to
GlobalXYVisualizerasgif_name, so--save-gifregenerates that GIF instead of opening the window. Without--save-gif,GlobalXYVisualizerstill callsplt.show().Updated:
extended_kalman_filter_localizationunscented_kalman_filter_localizationparticle_filter_localizationekf_vs_ukf_comparisonekf_ukf_pf_comparisonNo GIFs were regenerated in this PR.
How I checked it works
python3 -m pytest test/test_ekf_localization_path_tracking.py test/test_ukf_localization_path_tracking.py test/test_pf_localization_path_tracking.py test/test_ekf_vs_ukf_comparison.py test/test_ekf_ukf_pf_comparison.py— 5 passed.--save-gifoverwrites the same file.Images
Not needed: the behavior and the committed GIFs are unchanged; only the
gif_nameargument is now passed.