Skip to content

Localization: pass gif_name to GlobalXYVisualizer - #232

Open
DeviousCardi wants to merge 1 commit into
ShisatoYano:mainfrom
DeviousCardi:localization-save-gif
Open

DeviousCardi wants to merge 1 commit into
ShisatoYano:mainfrom
DeviousCardi:localization-save-gif

Conversation

@DeviousCardi

Copy link
Copy Markdown

Summary

Closes #231 (Localization category).

Passes each localization simulation's committed GIF path to GlobalXYVisualizer as gif_name, so --save-gif regenerates that GIF instead of opening the window. Without --save-gif, GlobalXYVisualizer still calls plt.show().

Updated:

  • extended_kalman_filter_localization
  • unscented_kalman_filter_localization
  • particle_filter_localization
  • ekf_vs_ukf_comparison
  • ekf_ukf_pf_comparison

No GIFs were regenerated in this PR.

How I checked it works

  • python3 -m pytest test/test_ekf_localization_path_tracking.py test/test_ukf_localization_path_tracking.py test/test_pf_localization_path_tracking.py test/test_ekf_vs_ukf_comparison.py test/test_ekf_ukf_pf_comparison.py — 5 passed.
  • Each script now uses the existing committed GIF name, so --save-gif overwrites the same file.

Images

Not needed: the behavior and the committed GIFs are unchanged; only the gif_name argument is now passed.

@ShisatoYano ShisatoYano added the enhancement New feature or request label Nov 15, 2026
@ShisatoYano
ShisatoYano self-requested a review November 15, 2026 21:51
@ShisatoYano

Copy link
Copy Markdown
Owner

Thank you, @DeviousCardi, for taking the first category of #231! The change is exactly what the issue asked for: the existing GIF names, no regenerated GIFs, and a clear PR description.

I checked it locally: the five tests pass, Path is already imported in each script, and running extended_kalman_filter_localization.py --save-gif now overwrites the committed extended_kalman_filter_localization.gif (in about 15 s) instead of opening the window.

One request before merging:

  1. Please change "Closes Let every simulation with a committed GIF regenerate it with --save-gif #231" in the description to "Part of Let every simulation with a committed GIF regenerate it with --save-gif #231". With "Closes", GitHub closes the issue when this PR is merged, but Let every simulation with a committed GIF regenerate it with --save-gif #231 covers 16 simulations in four categories, and this PR does the five of Localization.

🤖 Generated with Claude Code

@ShisatoYano ShisatoYano added the no images needed A change under src/ with nothing to show in images (checked by PR_Evidence) label Nov 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request no images needed A change under src/ with nothing to show in images (checked by PR_Evidence)

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Let every simulation with a committed GIF regenerate it with --save-gif

2 participants