Skip to content

[Tests] Fix flaky outdated rate-limit cache test #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Suleimanlatrsh merged 1 commit into from
Sep 30, 2026
+4 −1
Merged

[Tests] Fix flaky outdated rate-limit cache test #8705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/cli-kit/src/private/node/conf-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
getCachedPartnerAccountStatus,
setCachedPartnerAccountStatus,
runWithRateLimit,
timeIntervalToMilliseconds,
} from './conf-store.js'
import {isLocalEnvironment} from './context/service.js'
import {LocalStorage} from '../../public/node/local-storage.js'
Expand Down Expand Up @@ -548,6 +549,7 @@ describe('runWithRateLimit', () => {
test('runs the task as usual when the cache is populated but outdated', async () => {
await inTemporaryDirectory(async (cwd) => {
// Given
vi.useFakeTimers()
const config = new LocalStorage<any>({cwd})
for (let i = 0; i < limit; i++) {
// eslint-disable-next-line no-await-in-loop
Expand All @@ -564,7 +566,8 @@ describe('runWithRateLimit', () => {

// When
let taskRan = false
vi.setSystemTime(vi.getRealSystemTime() + 1000)
// The rate-limit window is inclusive of its start, so advance strictly past it.
vi.advanceTimersByTime(timeIntervalToMilliseconds(timeout) + 1)
const got = await runWithRateLimit(
{
key,
Expand Down
Loading