[Refactor] Collect requested token IDs declaratively in validateSession - #8706
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Replace four near-identical if blocks that each mutated a tokensAreExpired accumulator with a single list of requested token IDs checked via Array.prototype.some. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
validateSessiondecided whether any requested token was expired using fournear-identical
ifblocks, each re-deriving an application ID and thenre-assigning a shared
tokensAreExpiredaccumulator. The repetition made ithard to see at a glance which applications are checked, and adding a new
application meant copying the block a fifth time.
WHAT is this pull request doing?
Collect the requested application token IDs into a single list and check them
with
Array.prototype.some, so the expiry check reads as one expressioninstead of four mutations of a shared variable.
businessPlatformApiremainsunchecked, exactly as before.
Behavior is unchanged:
isTokenExpiredis pure and the original||chainalready short-circuited, so
.some()evaluates the same tokens to the sameresult.
How to manually test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add