Repository navigation
fix(diagnostics): parse after queued document changes - #4249
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4247. A diagnostic request can be read before the worker applies the preceding
didChange, leaving diagnostics based on a stale parse tree.Implementation
Parse documents in the serial worker immediately before handling each request, after earlier queued document notifications have been applied.
Automated Tests
Added a deterministic regression test for a queued change followed by a diagnostic request. It fails on pristine
mainand passes with this fix.bundle exec rake testpassed (3,557 tests, 62,503 assertions, 6 skips); Sorbet and RuboCop passed. The indexer suite passed with one environment-sensitive path test excluded; that test also fails on pristinemainbecause of the local RDoc gem path.Manual Tests
Not run.