Repository navigation
Use Playwright 1.65.1, which supports Ubuntu 26.04 - #1400
Merged
Merged
Conversation
GitHub is moving `ubuntu-latest` to Ubuntu 26.04. On those runners, Playwright 1.60.0's `@playwright/browser-chromium` install script throws "Playwright does not support chromium on ubuntu26.04-x64", so `pnpm install` fails before any test runs. 1.65.1 supports ubuntu26.04. The override pinned 1.60.0 for its Node 24 extraction fix (2eeb81c). It now pins 1.65.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
charlespwd
approved these changes
Nov 16, 2026
EvilGenius13
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
GitHub is moving
ubuntu-latestto Ubuntu 26.04, and CI fails on the jobs that land there, as on #1384:pnpm installruns that install script, so the Linux jobs fail before any test runs, and fail-fast cancels the Windows ones. Jobs that still getubuntu-24.04pass, so it depends on the runner.Playwright 1.65.1 supports
ubuntu26.04-x64, and 1.60.0 doesn't. This changes the rootpnpm.overridesfrom 1.60.0 to 1.65.1. The pin was added for 1.60.0's Node 24 extraction fix (2eeb81c), not to hold Playwright back.Tophatting
On macOS with Node 24:
pnpm install --frozen-lockfile@vscode/test-webresolves@playwright/browser-chromium1.65.1.pnpm build, thenpnpm test:e2e: 3 passing.I couldn't run it on Ubuntu 26.04 locally. This PR's CI only runs there if GitHub happens to give its jobs a 26.04 runner.
🤖 Generated with Claude Code