Warn on definitely undeclared checkout fulfillment methods - #70
Open
DeepanshuPal wants to merge 4 commits into
Open
DeepanshuPal wants to merge 4 commits into
DeepanshuPal wants to merge 4 commits into
Conversation
Added warning for unsupported fulfillment methods in checkout.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #46. The CLI now emits an advisory stderr warning when a checkout request names a fulfillment method definitely absent from the merchant profile's matching-version
allows_method_combinations. It still sends the request and tells the operator to check returned fulfillment and buyer state. Missing, malformed, version-mismatched, or ambiguous configuration remains silent and never blocks dispatch.This PR only adds a diagnostic. It does not claim that Shopify pickup is implemented, nor prescribe
continue_urlas a fallback.Verification: 978 non-integration tests passed; TypeScript typecheck, Biome on changed files, and diff check passed. Synthetic tests cover shipping-only pickup, mixed combinations, uncertain configuration, and the CLI warning-before-dispatch behavior.