Deprecate useLocalizationMarket and localization.market across surfaces - #4618
Open
SyndicateGit wants to merge 1 commit into
Open
Deprecate useLocalizationMarket and localization.market across surfaces#4618SyndicateGit wants to merge 1 commit into
useLocalizationMarket and localization.market across surfaces#4618SyndicateGit wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
needs-rc-port
Contributor
|
This PR targets a stable release branch ( When you open the forward-port PR, include a line like this in its body so the Accepted formats (comma-separated for multiple):
If a forward-port isn't needed (e.g., the change is stable-only), you can remove the |
SyndicateGit
marked this pull request as draft
August 13, 2026 21:14
SyndicateGit
changed the title
useLocalizationMarket and localization.market across surfaces
SyndicateGit
marked this pull request as ready for review
August 13, 2026 21:46
SyndicateGit
force-pushed
the
river-deprecate-use-localization-market
branch
2 times, most recently
from
August 13, 2026 22:07
1080d54 to
7a8b7c2
Compare
SyndicateGit
requested review from
a team,
cpeddecord,
jamesvidler and
kumar303
and removed request for
a team
August 13, 2026 22:22
kumar303
approved these changes
Aug 14, 2026
kumar303
left a comment
kumar303
left a comment
Contributor
There was a problem hiding this comment.
This looks good but was it actually deprecated in version 2026-07? Do you need to also (or only) merge it into the 2026-10-rc branch?
jamesvidler
approved these changes
Aug 14, 2026
SyndicateGit
force-pushed
the
river-deprecate-use-localization-market
branch
from
August 14, 2026 20:09
7a8b7c2 to
737f641
Compare
…rfaces Add `@deprecated` tag and `> Caution:` doc block to the `useLocalizationMarket` hook and `localization.market` property on both the checkout and customer-account surfaces. The shopify.dev migration guide already lists these as deprecated, but the source types had no deprecation annotation (hooks) or were missing the Caution block needed for docs rendering (property). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SyndicateGit
force-pushed
the
river-deprecate-use-localization-market
branch
from
August 14, 2026 20:12
737f641 to
fe9d3de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
@deprecatedJSDoc tags and> Caution:doc blocks touseLocalizationMarkethook andlocalization.marketproperty on both checkout and customer-account surfaces. Updates the property descriptions to clarify that in cases where multiple markets match, this returns the most narrowly scoped country region market.Why:
useLocalizationMarketis a one-line wrapper whose body isuseSubscription(localization.market). TypeScript does not propagate@deprecatedthrough a wrapper, so someone using the hook gets no warning today while someone using the property does.The
> Caution:block mirrors the pattern used byuseTarget,useExtensionApi,useExtensionData, anduseDeliveryGroupTarget, since the docs pipeline does not serialize@deprecatedfor top-level exported hooks.Companion PR in World: https://github.com/shop/world/pull/988628
Changes
checkout/api/standard/standard.ts— updates@deprecatedonlocalization.marketand adds> Caution:block; clarifies market scoping descriptioncheckout/preact/market.ts— adds@deprecatedand> Caution:touseLocalizationMarket; updates descriptioncustomer-account/api/order-status/order-status.ts— adds@deprecatedand> Caution:tolocalization.market; clarifies market scoping descriptioncustomer-account/preact/market.ts— adds@deprecatedand> Caution:touseLocalizationMarket; updates description@shopify/ui-extensionsTest plan
@deprecatedshows strikethrough/warning in IDE when usinguseLocalizationMarketorlocalization.market> Caution:block correctly🤖 Generated with Claude Code