Skip to content

Fix error resubscribe#3105

Open
KyuminAhn wants to merge 2 commits into
SmartThingsCommunity:mainfrom
KyuminAhn:fix/error-resubscribe
Open

Fix error resubscribe#3105
KyuminAhn wants to merge 2 commits into
SmartThingsCommunity:mainfrom
KyuminAhn:fix/error-resubscribe

Conversation

@KyuminAhn

Copy link
Copy Markdown
Contributor
  • Fix re-subscription timeout after hub replacement
  • fingerprints.yml: add matterManufacturer entries (AIHomeKit 0x1241/0x804E, BritzyHub 0x1436/0x800C) and tag generic device types with vendorId

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

KyuminAhn and others added 2 commits July 1, 2026 11:24
    - fingerprints.yml: add matterManufacturer entries (AIHomeKit 0x1241/0x804E, BritzyHub 0x1436/0x800C) and tag generic device types with vendorId
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Test Results

   73 files  ±0    521 suites  ±0   0s ⏱️ ±0s
3 009 tests ±0  3 009 ✅ ±0  0 💤 ±0  0 ❌ ±0 
4 927 runs  ±0  4 927 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ab8c4d. ± Comparison against base commit f8e07b8.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0ab8c4d

local MatterDriver = require "st.matter.driver"
local log = require "log"

local function bridge_init(driver, device)

@ctowns ctowns Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the issue is that there was no subscription being sent my the bridge device if this bridge_init function was not previously populated?

@DongHoon-Ryu could you check if just removing this function causes the issue to occur again during hub replace? And then if adding it back fixes the issue?

The reason I am more suspicious of this is because the other subscribe logic above is very similar to what already exists in the subscribe function, so I'm not sure yet how that is providing a change in functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants