Aligned handlers and fields in value magnitude and added tests#3111
Open
aleclorimer wants to merge 2 commits into
Open
Aligned handlers and fields in value magnitude and added tests#3111aleclorimer wants to merge 2 commits into
aleclorimer wants to merge 2 commits into
Conversation
|
Invitation URL: |
Test Results 73 files 537 suites 0s ⏱️ Results for commit 2376ac9. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2376ac9 |
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
from
e2b0384 to
08a32b8
Compare
varzac
reviewed
Jul 9, 2026
| local setpoint_limit_handler = function(limit_type) | ||
| return function(driver, device, limit) | ||
| device:set_field(limit_type, limit.value, {persist = true}) | ||
| device:set_field(limit_type, limit.value / 100.0, {persist = true}) |
Contributor
There was a problem hiding this comment.
While this will fix it for future devices, this value is already persisted on existing devices, so even though I think this change makes more sense in a vacuum, for this fix, I think we need to keep persisting in centidegrees (and comment that we are doing such) and then do this division on the checks. We'll have to update the DEFAULT values as well
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
2 times, most recently
from
aeac47a to
4254ba3
Compare
varzac
reviewed
Jul 10, 2026
| device:get_field(MAX_HEAT_LIMIT) or DEFAULT_MAX_SETPOINT) | ||
| device:get_field(MIN_COOL_LIMIT) or DEFAULT_MIN_SETPOINT, | ||
| device:get_field(MAX_COOL_LIMIT) or DEFAULT_MAX_SETPOINT) | ||
| device:set_field(COOLING_SETPOINT, value) |
Contributor
There was a problem hiding this comment.
Isn't this going to set the value in centidegrees, and then correspondingly the update_device_setpoint call will emit an invalid event?
varzac
reviewed
Jul 10, 2026
| cooling_setpoint = nil | ||
| elseif (current_mode == ModeAttribute.cool.NAME) and heating_setpoint ~= nil then | ||
| heating_setpoint = device:get_latest_state("main", ThermostatHeatingSetpoint.ID, ThermostatHeatingSetpoint.heatingSetpoint.NAME) | ||
| device:emit_event(ThermostatHeatingSetpoint.heatingSetpoint({value = heating_setpoint, unit = "C"})) |
Contributor
There was a problem hiding this comment.
Won't this be multiplied by 100 now?
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
from
4254ba3 to
55f504a
Compare
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
from
55f504a to
2376ac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where
(min|max)(Heat|Cool)SetPointwas being set in centidegrees and then being used to clamp a value in degrees causing the clamped value to have an Int16 overflow error when then tried to scale to centidegrees.Mutant testing: Failing without the
/ 100.0fix/update.